This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19107 ) Change subject: bts-trx: Introduce rate counter for scheduler timerfd missed FNs ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h@57 PS1, Line 57: /* bts-trx specific rate counters */ > Given that we're in 'osmo-bts-trx' directory, everything is osmo-bts-trx specific here... We should drop all comments containing "osmo-bts-trx" then? or what? It's already there 3 lines above. I don't see a problem with having it there. https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c File src/osmo-bts-trx/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c@67 PS1, Line 67: btstrx_ > Again, this prefix is redundant. We're not going to add e.g. […] I prefer having that way than having them unnamed, this way it's easy to understand everything in general but specific to osmo-bts-trx fits here. https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/scheduler_trx.c@161 PS1, Line 161: > unrelated change It's in the same block being changed anyway, and it's cosmetic since I'm adding stuff on the line below, so i think it fits here. It would be the same as if I add {} or a new conditional block and I need to indent stuff around. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0051b9ab18ebc9f92db11374d856de94f155efa4 Gerrit-Change-Number: 19107 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 05 Jul 2020 16:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200705/5fb0f0b5/attachment.htm>