Change in osmo-bts[master]: bts-trx: Introduce rate counter for scheduler timerfd missed FNs

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19107 )

Change subject: bts-trx: Introduce rate counter for scheduler timerfd missed FNs
......................................................................


Patch Set 1:

(5 comments)

Mostly cosmetic warnings (Neels style).

https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h 
File src/osmo-bts-trx/l1_if.h:

https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/l1_if.h@57 
PS1, Line 57: /* bts-trx specific rate counters */
Given that we're in 'osmo-bts-trx' directory, everything is osmo-bts-trx specific here...


https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c 
File src/osmo-bts-trx/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c@65 
PS1, Line 65: 	[BTSTRX_CTR_SCHED_DL_MISS_FN] =	{"trx_clk:sched_dl_miss_fn", "Downlink frames scheduled later than expected due to missed timerfd event (due to high system load)"},
Let's please avoid adding long lines. This format:

{
  #NAME,
  #DESC,
}

would be more readable. Not critical.


https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c@67 
PS1, Line 67: btstrx_
Again, this prefix is redundant. We're not going to add e.g. sysmoBTS specific counters here, right?


https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/main.c@69 
PS1, Line 69: OsmoBtsTrx
This is very unusual. One place when we mostly use CamelCase is TTCN-3, but here it looks not natural.


https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/19107/1/src/osmo-bts-trx/scheduler_trx.c@161 
PS1, Line 161:      
unrelated change



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0051b9ab18ebc9f92db11374d856de94f155efa4
Gerrit-Change-Number: 19107
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Jul 2020 15:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200703/d866ed26/attachment.htm>