This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521 ) Change subject: Implement serial number string descriptor in CTRL EP callback ...................................................................... Patch Set 4: (1 comment) @Hoernchen, can you take this over? https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521/4/sysmoOCTSIM/usb_start.c File sysmoOCTSIM/usb_start.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521/4/sysmoOCTSIM/usb_start.c@78 PS4, Line 78: printf("Sending string %u from callback: ", req->wValue & 0x00ff); : printf("ep=0x%02x len_req=%u len_desc=%u, len_tx=%u, zlp=%u\r\n", do we want to have unconditional printf's in this code? Sure, it was useful during debug, but do we want it now? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I428972df2cd35c4a5d9774c8ca8ece5109927fa9 Gerrit-Change-Number: 16521 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 28 Jan 2020 21:44:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200128/b079b0cc/attachment.htm>