<p style="white-space: pre-wrap; word-wrap: break-word;">@Hoernchen, can you take this over?</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521/4/sysmoOCTSIM/usb_start.c">File sysmoOCTSIM/usb_start.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521/4/sysmoOCTSIM/usb_start.c@78">Patch Set #4, Line 78:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">printf("Sending string %u from callback: ", req->wValue & 0x00ff);<br>   printf("ep=0x%02x len_req=%u len_desc=%u, len_tx=%u, zlp=%u\r\n",<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">do we want to have unconditional printf's in this code? Sure, it was useful during debug, but do we want it now?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521">change 16521</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I428972df2cd35c4a5d9774c8ca8ece5109927fa9 </div>
<div style="display:none"> Gerrit-Change-Number: 16521 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Jan 2020 21:44:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>