Change in osmo-pcu[master]: tests/rlcmac: Fix missing commas with unexpected results

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jan 23 23:18:53 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16987 )


Change subject: tests/rlcmac: Fix missing commas with unexpected results
......................................................................

tests/rlcmac: Fix missing commas with unexpected results

It can be seen that decoding+encoding for one othe msg bugs generates
different packet than the first one. It's left as a future exercise to
investigate it since it's preventing fix of other issues.

Change-Id: Ia0f8cc224a4c38e80699f834fd83d4c0d99322ea
---
M tests/rlcmac/RLCMACTest.cpp
M tests/rlcmac/RLCMACTest.ok
2 files changed, 29 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/16987/1

diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index acfe56a..c607883 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -100,10 +100,10 @@
 	"47283c367513ba333004242b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment
 	"400820001a3904df0680efb3300b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment (EGPRS)
 	"40284f0000001009810c826f4406809dcecb2b2b2b2b2b", // Packet Uplink Assignment (EGPRS)
-	"4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b"  // Packet Uplink Ack Nack (EGPRS)
-	"4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b"
-	"412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b"
-	"41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b"
+	"4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Ack Nack (EGPRS)
+	"4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b", // Polling Request?
+	"412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b", // Packet Uplink Ack Nack?
+	"41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // System Info 13?
 	};
 
 	int testDataSize = sizeof(testData)/sizeof(testData[0]);
@@ -166,7 +166,7 @@
 	"400b8020000000000000002480e0032b2b2b2b2b2b2b2b", // Packet Downlink Ack/Nack
 	"4016713dc094270ca2ae57ef909006aa0fc0001f80222b", // Packet Resource Request
 	"40200ffc0021ec010b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // EPDAN
-	"400a9020000000000000003010012a0800132b2b2b2b2b"
+	"400a9020000000000000003010012a0800132b2b2b2b2b", // Packet Downlink Ack/Nack ?
 	};
 
 	int testDataSize = sizeof(testData)/sizeof(testData[0]);
diff --git a/tests/rlcmac/RLCMACTest.ok b/tests/rlcmac/RLCMACTest.ok
index d61c62f..1508cf3 100644
--- a/tests/rlcmac/RLCMACTest.ok
+++ b/tests/rlcmac/RLCMACTest.ok
@@ -56,6 +56,30 @@
 vector1 = 40243f2f000087b042b2b2b2b2b2b2b2b2b2b2b
 vector2 = 40243f2f000087b042b2b2b2b2b2b2b2b2b2b2b
 vector1 == vector2 : TRUE
+vector1 = 4913e0850884013a848b2b2b2b2b2b2b2b2b2b2b2b2b
+=========Start DECODE===========
++++++++++Finish DECODE++++++++++
+=========Start ENCODE=============
++++++++++Finish ENCODE+++++++++++
+vector1 = 4913e0850884013a848b2b2b2b2b2b2b2b2b2b2b2b2b
+vector2 = 4913432b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
+vector1 == vector2 : FALSE
+vector1 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b
+=========Start DECODE===========
++++++++++Finish DECODE++++++++++
+=========Start ENCODE=============
++++++++++Finish ENCODE+++++++++++
+vector1 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b
+vector2 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b
+vector1 == vector2 : TRUE
+vector1 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
+=========Start DECODE===========
++++++++++Finish DECODE++++++++++
+=========Start ENCODE=============
++++++++++Finish ENCODE+++++++++++
+vector1 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
+vector2 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
+vector1 == vector2 : TRUE
 *** testRlcMacUplink ***
  UPLINK 
 vector1 = 40e1e61d11d2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16987
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia0f8cc224a4c38e80699f834fd83d4c0d99322ea
Gerrit-Change-Number: 16987
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/7dfcc33c/attachment.htm>


More information about the gerrit-log mailing list