<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16987">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/rlcmac: Fix missing commas with unexpected results<br><br>It can be seen that decoding+encoding for one othe msg bugs generates<br>different packet than the first one. It's left as a future exercise to<br>investigate it since it's preventing fix of other issues.<br><br>Change-Id: Ia0f8cc224a4c38e80699f834fd83d4c0d99322ea<br>---<br>M tests/rlcmac/RLCMACTest.cpp<br>M tests/rlcmac/RLCMACTest.ok<br>2 files changed, 29 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/16987/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp</span><br><span>index acfe56a..c607883 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.cpp</span><br><span>+++ b/tests/rlcmac/RLCMACTest.cpp</span><br><span>@@ -100,10 +100,10 @@</span><br><span>         "47283c367513ba333004242b2b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Assignment</span><br><span>      "400820001a3904df0680efb3300b2b2b2b2b2b2b2b2b2b", // Packet Downlink Assignment (EGPRS)</span><br><span>    "40284f0000001009810c826f4406809dcecb2b2b2b2b2b", // Packet Uplink Assignment (EGPRS)</span><br><span style="color: hsl(0, 100%, 40%);">- "4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b"  // Packet Uplink Ack Nack (EGPRS)</span><br><span style="color: hsl(0, 100%, 40%);">-   "4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b"</span><br><span style="color: hsl(0, 100%, 40%);">-      "412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b"</span><br><span style="color: hsl(0, 100%, 40%);">-      "41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b"</span><br><span style="color: hsl(120, 100%, 40%);">+    "4024030f2f0000000087b0042b2b2b2b2b2b2b2b2b2b2b", // Packet Uplink Ack Nack (EGPRS)</span><br><span style="color: hsl(120, 100%, 40%);">+ "4913e00850884013a8048b2b2b2b2b2b2b2b2b2b2b2b2b", // Polling Request?</span><br><span style="color: hsl(120, 100%, 40%);">+       "412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b", // Packet Uplink Ack Nack?</span><br><span style="color: hsl(120, 100%, 40%);">+        "41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // System Info 13?</span><br><span>       };</span><br><span> </span><br><span>       int testDataSize = sizeof(testData)/sizeof(testData[0]);</span><br><span>@@ -166,7 +166,7 @@</span><br><span>       "400b8020000000000000002480e0032b2b2b2b2b2b2b2b", // Packet Downlink Ack/Nack</span><br><span>      "4016713dc094270ca2ae57ef909006aa0fc0001f80222b", // Packet Resource Request</span><br><span>       "40200ffc0021ec010b2b2b2b2b2b2b2b2b2b2b2b2b2b2b", // EPDAN</span><br><span style="color: hsl(0, 100%, 40%);">-    "400a9020000000000000003010012a0800132b2b2b2b2b"</span><br><span style="color: hsl(120, 100%, 40%);">+    "400a9020000000000000003010012a0800132b2b2b2b2b", // Packet Downlink Ack/Nack ?</span><br><span>    };</span><br><span> </span><br><span>       int testDataSize = sizeof(testData)/sizeof(testData[0]);</span><br><span>diff --git a/tests/rlcmac/RLCMACTest.ok b/tests/rlcmac/RLCMACTest.ok</span><br><span>index d61c62f..1508cf3 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.ok</span><br><span>+++ b/tests/rlcmac/RLCMACTest.ok</span><br><span>@@ -56,6 +56,30 @@</span><br><span> vector1 = 40243f2f000087b042b2b2b2b2b2b2b2b2b2b2b</span><br><span> vector2 = 40243f2f000087b042b2b2b2b2b2b2b2b2b2b2b</span><br><span> vector1 == vector2 : TRUE</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 4913e0850884013a848b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start DECODE===========</span><br><span>++++++++++Finish DECODE++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start ENCODE=============</span><br><span>++++++++++Finish ENCODE+++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 4913e0850884013a848b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector2 = 4913432b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 == vector2 : FALSE</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start DECODE===========</span><br><span>++++++++++Finish DECODE++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start ENCODE=============</span><br><span>++++++++++Finish ENCODE+++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector2 = 41243007fffffffffffffffefd19c7ba12b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 == vector2 : TRUE</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start DECODE===========</span><br><span>++++++++++Finish DECODE++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+=========Start ENCODE=============</span><br><span>++++++++++Finish ENCODE+++++++++++</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector2 = 41942b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span style="color: hsl(120, 100%, 40%);">+vector1 == vector2 : TRUE</span><br><span> *** testRlcMacUplink ***</span><br><span>  UPLINK </span><br><span> vector1 = 40e1e61d11d2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16987">change 16987</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16987"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia0f8cc224a4c38e80699f834fd83d4c0d99322ea </div>
<div style="display:none"> Gerrit-Change-Number: 16987 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>