Change in osmo-bsc[master]: VTY: fix writing of custom timer values to a configuration file

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16923 )

Change subject: VTY: fix writing of custom timer values to a configuration file
......................................................................

VTY: fix writing of custom timer values to a configuration file

Calling osmo_tdef_vty_write() twice: with and without the 'timer '
prefix definitely looks like a bug. After setting any timer to a
custom (non-default) value, config_write_net() would generate an
incorrect configuration file:

  $ osmo-bsc -c /tmp/osmo-bsc.cfg
  There is no such command.
  Error occurred during reading the below line:
    T10 10

Change-Id: I5cc893fb2077bb21f1f661e30a7ab2af1b9bd561
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 1195d65..d1a268d 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -1062,8 +1062,6 @@
 
 	ho_vty_write_net(vty, gsmnet);
 
-	osmo_tdef_vty_write(vty, gsmnet->T_defs, " ");
-
 	if (!gsmnet->dyn_ts_allow_tch_f)
 		vty_out(vty, " dyn_ts_allow_tch_f 0%s", VTY_NEWLINE);
 	if (gsmnet->tz.override != 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5cc893fb2077bb21f1f661e30a7ab2af1b9bd561
Gerrit-Change-Number: 16923
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/66dd331c/attachment.htm>