<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16923">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: fix writing of custom timer values to a configuration file<br><br>Calling osmo_tdef_vty_write() twice: with and without the 'timer '<br>prefix definitely looks like a bug. After setting any timer to a<br>custom (non-default) value, config_write_net() would generate an<br>incorrect configuration file:<br><br>  $ osmo-bsc -c /tmp/osmo-bsc.cfg<br>  There is no such command.<br>  Error occurred during reading the below line:<br>    T10 10<br><br>Change-Id: I5cc893fb2077bb21f1f661e30a7ab2af1b9bd561<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 1195d65..d1a268d 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -1062,8 +1062,6 @@</span><br><span> </span><br><span>    ho_vty_write_net(vty, gsmnet);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      osmo_tdef_vty_write(vty, gsmnet->T_defs, " ");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  if (!gsmnet->dyn_ts_allow_tch_f)</span><br><span>          vty_out(vty, " dyn_ts_allow_tch_f 0%s", VTY_NEWLINE);</span><br><span>      if (gsmnet->tz.override != 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/16923">change 16923</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/16923"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5cc893fb2077bb21f1f661e30a7ab2af1b9bd561 </div>
<div style="display:none"> Gerrit-Change-Number: 16923 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>