Change in osmo-ttcn3-hacks[master]: hlr: f_perform_UL: add CnDomain parameter

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911 )

Change subject: hlr: f_perform_UL: add CnDomain parameter
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Not a merge blocker, but might be a desirable feature.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn 
File library/GSUP_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn@498 
PS2, Line 498: GSUP_CnDomain dom
Since this IE is optional, we should allow passing omit:

  template (omit) ts_GSUP_UL_REQ dom := omit


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn@500 
PS2, Line 500: valueof(ts_GSUP_IE_CnDomain(dom))
... but handling optional IEs here is a bit complicated. You would need a function returning the list of IEs, because you cannot just pass omit to ts_GSUP_IE_CnDomain.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idd699f054c9242614b9bea066428293f8b2da9c2
Gerrit-Change-Number: 16911
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Jan 2020 14:11:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200117/88545aa1/attachment.htm>