<p style="white-space: pre-wrap; word-wrap: break-word;">Not a merge blocker, but might be a desirable feature.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn">File library/GSUP_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn@498">Patch Set #2, Line 498:</a> <code style="font-family:monospace,monospace">GSUP_CnDomain dom</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since this IE is optional, we should allow passing omit:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  template (omit) ts_GSUP_UL_REQ dom := omit</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911/2/library/GSUP_Types.ttcn@500">Patch Set #2, Line 500:</a> <code style="font-family:monospace,monospace">valueof(ts_GSUP_IE_CnDomain(dom))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">... but handling optional IEs here is a bit complicated. You would need a function returning the list of IEs, because you cannot just pass omit to ts_GSUP_IE_CnDomain.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911">change 16911</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16911"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idd699f054c9242614b9bea066428293f8b2da9c2 </div>
<div style="display:none"> Gerrit-Change-Number: 16911 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 17 Jan 2020 14:11:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>