Change in osmo-trx[master]: lms: Store device type specific parameters in one place

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16876 )

Change subject: lms: Store device type specific parameters in one place
......................................................................


Patch Set 1:

(6 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h 
File Transceiver52M/device/lms/LMSDevice.h:

https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@48 
PS1, Line 48: LMS_DEV_UNKNOWN
Maybe rather keep this one first, so it will be 0?


https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@70 
PS1, Line 70: dev_type
Also, how about adding prefix 'm_'?


https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@70 
PS1, Line 70: dev_type
... so unless we explicitly initialize this field, we fall-back to UNKNOWN? (see my comment above)


https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp 
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@51 
PS1, Line 51: Device Name Prefixes
How about using value_string array here?


https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@245 
PS1, Line 245: /* FIXME make external reference frequency configurable */
should we still keep this comment? As far as I can see, you're checking if it's supported now...


https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@275 
PS1, Line 275: else
So if !dev_desc.clock_src_switchable, we would print this log message twice? Or at least once if it's actually supported. Maybe you need a conditional else branch:

  ... } else if (!dev_desc.clock_src_switchable) { ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/16876
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I7658615787c5bc41c365bab9c11733b701ac2ae5
Gerrit-Change-Number: 16876
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 15 Jan 2020 02:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200115/3fe377b0/attachment.htm>