<p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h">File Transceiver52M/device/lms/LMSDevice.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@48">Patch Set #1, Line 48:</a> <code style="font-family:monospace,monospace">LMS_DEV_UNKNOWN</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe rather keep this one first, so it will be 0?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@70">Patch Set #1, Line 70:</a> <code style="font-family:monospace,monospace">dev_type</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Also, how about adding prefix 'm_'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.h@70">Patch Set #1, Line 70:</a> <code style="font-family:monospace,monospace">dev_type</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">... so unless we explicitly initialize this field, we fall-back to UNKNOWN? (see my comment above)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp">File Transceiver52M/device/lms/LMSDevice.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@51">Patch Set #1, Line 51:</a> <code style="font-family:monospace,monospace">Device Name Prefixes</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about using value_string array here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@245">Patch Set #1, Line 245:</a> <code style="font-family:monospace,monospace">/* FIXME make external reference frequency configurable */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should we still keep this comment? As far as I can see, you're checking if it's supported now...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876/1/Transceiver52M/device/lms/LMSDevice.cpp@275">Patch Set #1, Line 275:</a> <code style="font-family:monospace,monospace">else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So if !dev_desc.clock_src_switchable, we would print this log message twice? Or at least once if it's actually supported. Maybe you need a conditional else branch:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  ... } else if (!dev_desc.clock_src_switchable) { ...</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/16876">change 16876</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/16876"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7658615787c5bc41c365bab9c11733b701ac2ae5 </div>
<div style="display:none"> Gerrit-Change-Number: 16876 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 15 Jan 2020 02:32:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>