This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16832 ) Change subject: logging.c: Add valuestrings for loglevels ...................................................................... Patch Set 1: Code-Review-1 (2 comments) I don't see how this can be useful as you don't add any use case for it in the commit description. Furthermore, we already have loglevel_strs. https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c@67 PS1, Line 67: const struct value_string log_level_names[] = { We already have something like that, don't re-add the same content: const struct value_string loglevel_strs[] = { { LOGL_DEBUG, "DEBUG" }, { LOGL_INFO, "INFO" }, { LOGL_NOTICE, "NOTICE" }, { LOGL_ERROR, "ERROR" }, { LOGL_FATAL, "FATAL" }, { 0, NULL }, }; https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c@68 PS1, Line 68: { LOGL_DEBUG, "LOGL_DEBUG" }, OSMO_STRINGIFY(LOGL_DEBUG) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e58dbae9889f1424ff107a22ed0e838bea7f5b Gerrit-Change-Number: 16832 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2020 14:40:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200113/adf3d607/attachment.htm>