<p style="white-space: pre-wrap; word-wrap: break-word;">I don't see how this can be useful as you don't add any use case for it in the commit description.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Furthermore, we already have loglevel_strs.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16832">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c">File src/logging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c@67">Patch Set #1, Line 67:</a> <code style="font-family:monospace,monospace">const struct value_string log_level_names[] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We already have something like that, don't re-add the same content:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> const struct value_string loglevel_strs[] = {<br>  { LOGL_DEBUG,   "DEBUG" },<br>  { LOGL_INFO,    "INFO" },<br>   { LOGL_NOTICE,  "NOTICE" },<br> { LOGL_ERROR,   "ERROR" },<br>  { LOGL_FATAL,   "FATAL" },<br>  { 0, NULL },<br>};</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/16832/1/src/logging.c@68">Patch Set #1, Line 68:</a> <code style="font-family:monospace,monospace"> { LOGL_DEBUG,           "LOGL_DEBUG" },</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_STRINGIFY(LOGL_DEBUG)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16832">change 16832</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16832"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I81e58dbae9889f1424ff107a22ed0e838bea7f5b </div>
<div style="display:none"> Gerrit-Change-Number: 16832 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 13 Jan 2020 14:40:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>