Change in osmo-ttcn3-hacks[master]: Add SCCP_Tests_RAW for testing the actual SCCP implementation

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814 )

Change subject: Add SCCP_Tests_RAW for testing the actual SCCP implementation
......................................................................


Patch Set 1: Code-Review+1

(6 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_CodecPort.ttcn 
File sccp/SCCP_CodecPort.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_CodecPort.ttcn@4 
PS1, Line 4:  * octetstring payload towards the MTP3 imovider, and MTP3-SCCP primitives
imovider is an IM provider? or an immobile provider? :P


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg 
File sccp/SCCP_Tests_RAW.cfg:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg@17 
PS1, Line 17: SCCP_Tests.sccp_cfg := {
mp_sccp_cfg


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg@20 
PS1, Line 20: 			//sctp_addr := { 2905, "127.0.0.1", 2905, "127.0.0.2" },
this line can be dropped I guess


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn 
File sccp/SCCP_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@4 
PS1, Line 4:  * The idea is that these tests are executed against sccp_demo_user from
Worth writing examples/sccp_demo_user since it's not installed.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@36 
PS1, Line 36: 	 * "System Under Test" is libosmo-sccp's sccp_demo_user example program. */
Worth writing examples/sccp_demo_user since it's not installed.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@160 
PS1, Line 160: 	
whitespace



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I07c43cfac9cdbdeccf102cd08309ca9ec64968cc
Gerrit-Change-Number: 16814
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Jan 2020 09:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200113/1edd9620/attachment.htm>