<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_CodecPort.ttcn">File sccp/SCCP_CodecPort.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_CodecPort.ttcn@4">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * octetstring payload towards the MTP3 imovider, and MTP3-SCCP primitives</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">imovider is an IM provider? or an immobile provider? :P</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg">File sccp/SCCP_Tests_RAW.cfg:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace">SCCP_Tests.sccp_cfg := {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">mp_sccp_cfg</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.cfg@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace"> //sctp_addr := { 2905, "127.0.0.1", 2905, "127.0.0.2" },</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this line can be dropped I guess</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn">File sccp/SCCP_Tests_RAW.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@4">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> * The idea is that these tests are executed against sccp_demo_user from</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Worth writing examples/sccp_demo_user since it's not installed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> * "System Under Test" is libosmo-sccp's sccp_demo_user example program. */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Worth writing examples/sccp_demo_user since it's not installed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814/1/sccp/SCCP_Tests_RAW.ttcn@160">Patch Set #1, Line 160:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814">change 16814</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I07c43cfac9cdbdeccf102cd08309ca9ec64968cc </div>
<div style="display:none"> Gerrit-Change-Number: 16814 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Assignee: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 13 Jan 2020 09:57:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>