This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738 ) Change subject: MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS ...................................................................... MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS Since [1] we started to match the SMSC Address in f_mt_sms_expect(). That change caused test case failures because OsmoMSC hard-codes a different SMSC Address. Let's fix this. [1] Ib467eeca6439bc6cce72293fbb5bb48f6d233db9 Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index ccebba1..eae5e56 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1660,8 +1660,9 @@ rp := { msg_ref := '42'O, /* We don't really need to have both SM-RP-DA/OA here, because only one IE - * is included in MO/MT SMS, and in the most cases it's the SMSC address. */ - smsc_addr := t_RP_Addr('76722337'H) + * is included in MO/MT SMS, and in the most cases it's the SMSC address. + * NOTE: this address is currently hard-coded by OsmoMSC. */ + smsc_addr := t_RP_Addr('447785016005'H) }, tid := 0, dlci := '03'O, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b Gerrit-Change-Number: 16738 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200105/1400cab6/attachment.htm>