<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC: fix SM-RP-OA (SMSC Address) expectations for MT SMS<br><br>Since [1] we started to match the SMSC Address in f_mt_sms_expect().<br>That change caused test case failures because OsmoMSC hard-codes<br>a different SMSC Address. Let's fix this.<br><br>[1] Ib467eeca6439bc6cce72293fbb5bb48f6d233db9<br><br>Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index ccebba1..eae5e56 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -1660,8 +1660,9 @@</span><br><span>     rp := {</span><br><span>              msg_ref := '42'O,</span><br><span>            /* We don't really need to have both SM-RP-DA/OA here, because only one IE</span><br><span style="color: hsl(0, 100%, 40%);">-           * is included in MO/MT SMS, and in the most cases it's the SMSC address. */</span><br><span style="color: hsl(0, 100%, 40%);">-                smsc_addr := t_RP_Addr('76722337'H)</span><br><span style="color: hsl(120, 100%, 40%);">+            * is included in MO/MT SMS, and in the most cases it's the SMSC address.</span><br><span style="color: hsl(120, 100%, 40%);">+          * NOTE: this address is currently hard-coded by OsmoMSC. */</span><br><span style="color: hsl(120, 100%, 40%);">+          smsc_addr := t_RP_Addr('447785016005'H)</span><br><span>      },</span><br><span>   tid := 0,</span><br><span>    dlci := '03'O,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738">change 16738</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16738"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3bdb6a74c8b02e4bf8dc88634e2380c924242b4b </div>
<div style="display:none"> Gerrit-Change-Number: 16738 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>