Change in osmo-remsim[master]: server: don't dereference map before OSMO_ASSERT() in _update_client_...

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/17183 )

Change subject: server: don't dereference map before OSMO_ASSERT() in _update_client_for_slotmap()
......................................................................

server: don't dereference map before OSMO_ASSERT() in _update_client_for_slotmap()

Change-Id: Ib36d2ba7928ea17a508cb68748e6c50f22784227
---
M src/server/rspro_server.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c
index 0d059fa..723aac8 100644
--- a/src/server/rspro_server.c
+++ b/src/server/rspro_server.c
@@ -219,7 +219,7 @@
 static void _update_client_for_slotmap(struct slot_mapping *map, struct rspro_server *srv,
 					struct rspro_client_conn *bankd_conn)
 {
-	struct rspro_client_conn *conn = client_conn_by_slot(srv, &map->client);
+	struct rspro_client_conn *conn;
 	char ip_str[INET6_ADDRSTRLEN];
 	char port_str[6];
 	uint32_t bankd_ip;
@@ -230,6 +230,7 @@
 	OSMO_ASSERT(map);
 	OSMO_ASSERT(srv);
 
+	conn = client_conn_by_slot(srv, &map->client);
 	if (!conn)
 		LOGP(DMAIN, LOGL_DEBUG, "%s\n", __func__);
 	else

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/17183
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ib36d2ba7928ea17a508cb68748e6c50f22784227
Gerrit-Change-Number: 17183
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200216/953a77df/attachment.htm>