<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17183">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">server: don't dereference map before OSMO_ASSERT() in _update_client_for_slotmap()<br><br>Change-Id: Ib36d2ba7928ea17a508cb68748e6c50f22784227<br>---<br>M src/server/rspro_server.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c</span><br><span>index 0d059fa..723aac8 100644</span><br><span>--- a/src/server/rspro_server.c</span><br><span>+++ b/src/server/rspro_server.c</span><br><span>@@ -219,7 +219,7 @@</span><br><span> static void _update_client_for_slotmap(struct slot_mapping *map, struct rspro_server *srv,</span><br><span>                                       struct rspro_client_conn *bankd_conn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      struct rspro_client_conn *conn = client_conn_by_slot(srv, &map->client);</span><br><span style="color: hsl(120, 100%, 40%);">+       struct rspro_client_conn *conn;</span><br><span>      char ip_str[INET6_ADDRSTRLEN];</span><br><span>       char port_str[6];</span><br><span>    uint32_t bankd_ip;</span><br><span>@@ -230,6 +230,7 @@</span><br><span>     OSMO_ASSERT(map);</span><br><span>    OSMO_ASSERT(srv);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ conn = client_conn_by_slot(srv, &map->client);</span><br><span>        if (!conn)</span><br><span>           LOGP(DMAIN, LOGL_DEBUG, "%s\n", __func__);</span><br><span>         else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17183">change 17183</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/17183"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib36d2ba7928ea17a508cb68748e6c50f22784227 </div>
<div style="display:none"> Gerrit-Change-Number: 17183 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>