Change in osmo-pcu[master]: Fix trailing newline mess with LOGP(C) in rlcmac/csn1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Feb 5 11:06:18 UTC 2020


Hello fixeria, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/17088

to look at the new patch set (#3).

Change subject: Fix trailing newline mess with LOGP(C) in rlcmac/csn1
......................................................................

Fix trailing newline mess with LOGP(C) in rlcmac/csn1

Output was incorrect before this patch. LOPC was being called without
having any initial LOGP, and trailing newline was usually missing at the
end.

Since csnDecoder/encoder functions are recursive, it's difficult to
handle logging state in a coherent way inside them. Let's better simply
control start/end of logging related topics in the callers of those
functions, and simply use LOGPC everywhere in csn1.cpp.

Change-Id: I50da7560939fac360b7545e2a6bfaf45ed0c4832
---
M src/csn1.cpp
M src/gsm_rlcmac.cpp
2 files changed, 38 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/88/17088/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I50da7560939fac360b7545e2a6bfaf45ed0c4832
Gerrit-Change-Number: 17088
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200205/ced0846f/attachment.htm>


More information about the gerrit-log mailing list