Change in osmo-pcu[master]: Fix trailing newline mess with LOGP(C) in rlcmac/csn1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Feb 5 00:08:22 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17088 )

Change subject: Fix trailing newline mess with LOGP(C) in rlcmac/csn1
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17088/2/src/gsm_rlcmac.cpp 
File src/gsm_rlcmac.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17088/2/src/gsm_rlcmac.cpp@4828 
PS2, Line 4828: 
ws


https://gerrit.osmocom.org/c/osmo-pcu/+/17088/2/src/gsm_rlcmac.cpp@4836 
PS2, Line 4836: LOGL_INFO
Huh, all LOGPC statements I've ever seen use NOTICE for some reason. Makes sense to use INFO for them too, or even DEBUG.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I50da7560939fac360b7545e2a6bfaf45ed0c4832
Gerrit-Change-Number: 17088
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 00:08:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200205/82f7712c/attachment.htm>


More information about the gerrit-log mailing list