Change in osmo-e1-hardware[master]: icE1usb fw: USB control request handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 27 16:36:19 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775 )

Change subject: icE1usb fw: USB control request handling
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c 
File firmware/ice40-riscv/icE1usb/e1.c:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c@256 
PS3, Line 256: 	g_e1.tx.cr = E1_TX_CR_UNFL_CLR | E1_TX_CR_ENABLE |tx_cr;
> space missing. […]
Ack


https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c@267 
PS3, Line 267: 	printf("tx_cfg(0x%04x)\n", cr);
> Left over debug ?
Ack


https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/ice1usb_proto.h 
File firmware/ice40-riscv/icE1usb/ice1usb_proto.h:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/ice1usb_proto.h@1 
PS3, Line 1: #pragma once
> Again, try to stick with the file header and comment style.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I9d28566ba21a2a78def5e4a0ba07ecbc4a583aa9
Gerrit-Change-Number: 21775
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 27 Dec 2020 16:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201227/ea89f35e/attachment.htm>


More information about the gerrit-log mailing list