<p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c">File firmware/ice40-riscv/icE1usb/e1.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c@256">Patch Set #3, Line 256:</a> <code style="font-family:monospace,monospace">        g_e1.tx.cr = E1_TX_CR_UNFL_CLR | E1_TX_CR_ENABLE |tx_cr;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">space missing. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/e1.c@267">Patch Set #3, Line 267:</a> <code style="font-family:monospace,monospace"> printf("tx_cfg(0x%04x)\n", cr);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Left over debug ?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/ice1usb_proto.h">File firmware/ice40-riscv/icE1usb/ice1usb_proto.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775/3/firmware/ice40-riscv/icE1usb/ice1usb_proto.h@1">Patch Set #3, Line 1:</a> <code style="font-family:monospace,monospace">#pragma once</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Again, try to stick with the file header and comment style.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775">change 21775</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21775"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d28566ba21a2a78def5e4a0ba07ecbc4a583aa9 </div>
<div style="display:none"> Gerrit-Change-Number: 21775 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 27 Dec 2020 16:36:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>