Change in osmo-e1-hardware[master]: icE1usb fw: Put E1 IP core register related #defines in e1_hw.h

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Sun Dec 20 17:30:30 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773 )

Change subject: icE1usb fw: Put E1 IP core register related #defines in e1_hw.h
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h 
File firmware/ice40-riscv/icE1usb/e1_hw.h:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h@1 
PS2, Line 1: #pragma once
Keep with the style of the other header.

/*
 * ...
 */

#pragma once

#include <sting.h>


https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h@10 
PS2, Line 10: //TODO: Shouldn't this go into the no2e1 git repo?
Yeah, it should, that's the plan.

Probably along with some "independent" parts of of the e1 driver too.

But for now it can live here until I have a better view of the split.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I6783f473e6bb7dd08a5b5714bdd9b5aac0f28f0d
Gerrit-Change-Number: 21773
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 20 Dec 2020 17:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/0b17a6f8/attachment.htm>


More information about the gerrit-log mailing list