<p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h">File firmware/ice40-riscv/icE1usb/e1_hw.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace">#pragma once</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Keep with the style of the other header.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/*<br> * ...<br> */</pre><p style="white-space: pre-wrap; word-wrap: break-word;">#pragma once</p><p style="white-space: pre-wrap; word-wrap: break-word;">#include <sting.h></p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773/2/firmware/ice40-riscv/icE1usb/e1_hw.h@10">Patch Set #2, Line 10:</a> <code style="font-family:monospace,monospace">//TODO: Shouldn't this go into the no2e1 git repo?</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah, it should, that's the plan.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably along with some "independent" parts of of the e1 driver too.</p><p style="white-space: pre-wrap; word-wrap: break-word;">But for now it can live here until I have a better view of the split.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773">change 21773</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21773"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6783f473e6bb7dd08a5b5714bdd9b5aac0f28f0d </div>
<div style="display:none"> Gerrit-Change-Number: 21773 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 20 Dec 2020 17:30:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>