Change in osmo-e1d[master]: Evaluate received E and A bits in TS0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Sun Dec 20 11:07:46 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21808 )

Change subject: Evaluate received E and A bits in TS0
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/usb.c 
File src/usb.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/usb.c@121 
PS2, Line 121: 	return e1_line_demux_in(flow->line, buf + 4, size - 4, buf[3]);
That byte should contain more than the frame number inside the multiframe, the MSB will be used to count multiframes, so some masking would be needed since that function seems to expect only the frame inside the multi-frame.

Also a usb packet can contain several multiframes, it can contain frames from up to 3 multiframes: End of the previous one, full multiframe, beginning of the next one.

(since with adaptive flow rate we can get larger packets)

So maybe the demux_in should actually take that into account.


https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c 
File src/vpair.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c@135 
PS2, Line 135: 		rc = e1_line_demux_in(peer, buf, rc, 0);
> basically we don't use TS0 at all in the vpair, as far as I can tell. […]
But all the TS0 processing will still happen and set flags and counters and all that stuff.
Maybe there needs to be a flag or special value so that all TS0 processing is disabled in muxer/demuxer then ?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I7e1c919518b3418e973b7ae5bedd5a6dd1c2adec
Gerrit-Change-Number: 21808
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sun, 20 Dec 2020 11:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/f8b7e64f/attachment.htm>


More information about the gerrit-log mailing list