<p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/usb.c">File src/usb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/usb.c@121">Patch Set #2, Line 121:</a> <code style="font-family:monospace,monospace"> return e1_line_demux_in(flow->line, buf + 4, size - 4, buf[3]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That byte should contain more than the frame number inside the multiframe, the MSB will be used to count multiframes, so some masking would be needed since that function seems to expect only the frame inside the multi-frame.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also a usb packet can contain several multiframes, it can contain frames from up to 3 multiframes: End of the previous one, full multiframe, beginning of the next one.</p><p style="white-space: pre-wrap; word-wrap: break-word;">(since with adaptive flow rate we can get larger packets)</p><p style="white-space: pre-wrap; word-wrap: break-word;">So maybe the demux_in should actually take that into account.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c">File src/vpair.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808/2/src/vpair.c@135">Patch Set #2, Line 135:</a> <code style="font-family:monospace,monospace"> rc = e1_line_demux_in(peer, buf, rc, 0);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">basically we don't use TS0 at all in the vpair, as far as I can tell. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">But all the TS0 processing will still happen and set flags and counters and all that stuff.<br>Maybe there needs to be a flag or special value so that all TS0 processing is disabled in muxer/demuxer then ?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808">change 21808</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/21808"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e1c919518b3418e973b7ae5bedd5a6dd1c2adec </div>
<div style="display:none"> Gerrit-Change-Number: 21808 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 20 Dec 2020 11:07:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>