This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21781 ) Change subject: vpair: fix writing config file with vpairs configured ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-e1d/+/21781/1/src/vty.c File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/21781/1/src/vty.c@195 PS1, Line 195: vty_out(vty, "pcu%s", VTY_NEWLINE); > shouldn't this be e1d? Ack https://gerrit.osmocom.org/c/osmo-e1d/+/21781/2/src/vty.c File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/21781/2/src/vty.c@192 PS2, Line 192: struct e1_intf *intf_b[256]; > 2k on the stack isn't great. […] I wouldn't really have worried about that kind of stack usage outside of a embedded device. But sure, it's not elegant, no doubt. Will change it. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iff6551318534a3717c374060082147f17b925a21 Gerrit-Change-Number: 21781 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 19 Dec 2020 17:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt at 246tNt.com> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/b0dae0e9/attachment.htm>