This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgtnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21781 ) Change subject: vpair: fix writing config file with vpairs configured ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-e1d/+/21781/2/src/vty.c File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/21781/2/src/vty.c@156 PS2, Line 156: "E1 Daemon sspecific configuration\n") Typo https://gerrit.osmocom.org/c/osmo-e1d/+/21781/2/src/vty.c@192 PS2, Line 192: struct e1_intf *intf_b[256]; 2k on the stack isn't great. Another approach to avoid duplicate would be to compare the pointers and only print if intf->id < intf_peer->id for instance. No memory needed. Also brings it to O(n) rather than O(n * log(n)) not that it matters for 256 max intf 😄 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iff6551318534a3717c374060082147f17b925a21 Gerrit-Change-Number: 21781 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 19 Dec 2020 17:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/d695fe5c/attachment.htm>