Change in libosmocore[master]: gprs_bssgp: add IE parser for RIM Routing Information

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21721 )

Change subject: gprs_bssgp: add IE parser for RIM Routing Information
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@197 
PS1, Line 197: 		struct {
             : 				uint16_t mcc;
             : 				uint16_t mnc;
             : 				bool mnc_3_digits;
             : 				uint16_t tac;
             : 			} tai;
> I have now seperated the struct, but I do not know exactly in which header file to put it. […]
it's probably the most correct course of action, yes.


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@204 
PS1, Line 204: uint8_t global_enb_id[8];
             : 			uint8_t global_enb_id_len;
> Same here, I am not sure where to put the struct.
I see that it is basically just a container of 22..32bits length, so we can keep this part as-is.  The comment could also reference 36.401.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11
Gerrit-Change-Number: 21721
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 16 Dec 2020 15:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/8e0855ca/attachment.htm>