Change in libosmocore[master]: gprs_bssgp: add IE parser for RIM Routing Information

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21721 )

Change subject: gprs_bssgp: add IE parser for RIM Routing Information
......................................................................


Patch Set 2:

(9 comments)

(ensure comments are sent)

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@197 
PS1, Line 197: 		struct {
             : 				uint16_t mcc;
             : 				uint16_t mnc;
             : 				bool mnc_3_digits;
             : 				uint16_t tac;
             : 			} tai;
> it might make sense to introduce a general/public 'struct' for this, like we have the gprs_ra_id. […]
I have now seperated the struct, but I do not know exactly in which header file to put it. Maybe we need to add a gsm_24_301.h - what do you think?


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@204 
PS1, Line 204: uint8_t global_enb_id[8];
             : 			uint8_t global_enb_id_len;
> likewise that might be wrappend in something like a public'struct osmo_g_enb_id'  - though I'm not s […]
Same here, I am not sure where to put the struct.


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@340 
PS1, Line 340: 		return 0;
> -EINVAL?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@347 
PS1, Line 347: 			return -1;
> return codes are not marching documentation.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@350 
PS1, Line 350: 		break;
> unneeded break.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@357 
PS1, Line 357: 		break;
> uneeded break.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@359 
PS1, Line 359: 		if (len < 7)
> You can probable merge both conditions in one if.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@374 
PS1, Line 374: 		break;
> unneeded break
Done


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@379 
PS1, Line 379: 	return 0;
> This cannot happen, you can remove it (or remove default above)
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11
Gerrit-Change-Number: 21721
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 16 Dec 2020 14:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/b1056066/attachment.htm>