Change in osmo-sgsn[master]: migrate to DLBSSGP as log sub-system for BSSGP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Dec 10 15:00:41 UTC 2020


daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21657 )

Change subject: migrate to DLBSSGP as log sub-system for BSSGP
......................................................................

migrate to DLBSSGP as log sub-system for BSSGP

Change-Id: I69ee10b6fad1da2053cf6f3ae99d3ecf62a144ce
Depends: libosmocore.git Change-Id I506190aae9217c0956e4b5764d1a0c0772268e93
---
M include/osmocom/sgsn/debug.h
M src/gbproxy/gb_proxy_main.c
M src/sgsn/sgsn_main.c
M tests/sgsn/sgsn_test.c
4 files changed, 2 insertions(+), 18 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index 29d500d..507b70c 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -24,7 +24,6 @@
 	DREF,
 	DGPRS,
 	DNS,
-	DBSSGP,
 	DLLC,
 	DSNDCP,
 	DSLHC,
diff --git a/src/gbproxy/gb_proxy_main.c b/src/gbproxy/gb_proxy_main.c
index c7ff78c..a9c132e 100644
--- a/src/gbproxy/gb_proxy_main.c
+++ b/src/gbproxy/gb_proxy_main.c
@@ -209,11 +209,6 @@
 		.description = "GPRS Network Service (NS)",
 		.enabled = 1, .loglevel = LOGL_INFO,
 	},
-	[DBSSGP] = {
-		.name = "DBSSGP",
-		.description = "GPRS BSS Gateway Protocol (BSSGP)",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
-	},
 };
 
 static const struct log_info gprs_log_info = {
@@ -288,7 +283,7 @@
 	}
 
 	gprs_ns2_vty_init(gbcfg->nsi, NULL);
-	bssgp_set_log_ss(DBSSGP);
+	logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "bssgp");
 	gprs_ns2_dynamic_create_nse(gbcfg->nsi, true);
 
 	bssgp_set_bssgp_callback(gbprox_bssgp_send_cb, gbcfg);
diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c
index e51336b..0277f6f 100644
--- a/src/sgsn/sgsn_main.c
+++ b/src/sgsn/sgsn_main.c
@@ -312,11 +312,6 @@
 		.description = "GPRS Network Service (NS)",
 		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
-	[DBSSGP] = {
-		.name = "DBSSGP",
-		.description = "GPRS BSS Gateway Protocol (BSSGP)",
-		.enabled = 1, .loglevel = LOGL_NOTICE,
-	},
 	[DLLC] = {
 		.name = "DLLC",
 		.description = "GPRS Logical Link Control Protocol (LLC)",
@@ -424,7 +419,7 @@
 	rate_ctr_init(tall_sgsn_ctx);
 
 	gprs_ns_set_log_ss(DNS);
-	bssgp_set_log_ss(DBSSGP);
+	logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "bssgp");
 
 	sgsn_nsi = gprs_ns_instantiate(&sgsn_ns_cb, tall_sgsn_ctx);
 	if (!sgsn_nsi) {
diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c
index 7399573..0574620 100644
--- a/tests/sgsn/sgsn_test.c
+++ b/tests/sgsn/sgsn_test.c
@@ -1625,11 +1625,6 @@
 		.description = "GPRS Network Service (NS)",
 		.enabled = 1, .loglevel = LOGL_INFO,
 	},
-	[DBSSGP] = {
-		.name = "DBSSGP",
-		.description = "GPRS BSS Gateway Protocol (BSSGP)",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
-	},
 	[DLLC] = {
 		.name = "DLLC",
 		.description = "GPRS Logical Link Control Protocol (LLC)",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21657
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I69ee10b6fad1da2053cf6f3ae99d3ecf62a144ce
Gerrit-Change-Number: 21657
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/a1eb6d43/attachment.htm>


More information about the gerrit-log mailing list