<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21657">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">migrate to DLBSSGP as log sub-system for BSSGP<br><br>Change-Id: I69ee10b6fad1da2053cf6f3ae99d3ecf62a144ce<br>Depends: libosmocore.git Change-Id I506190aae9217c0956e4b5764d1a0c0772268e93<br>---<br>M include/osmocom/sgsn/debug.h<br>M src/gbproxy/gb_proxy_main.c<br>M src/sgsn/sgsn_main.c<br>M tests/sgsn/sgsn_test.c<br>4 files changed, 2 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h</span><br><span>index 29d500d..507b70c 100644</span><br><span>--- a/include/osmocom/sgsn/debug.h</span><br><span>+++ b/include/osmocom/sgsn/debug.h</span><br><span>@@ -24,7 +24,6 @@</span><br><span> DREF,</span><br><span> DGPRS,</span><br><span> DNS,</span><br><span style="color: hsl(0, 100%, 40%);">- DBSSGP,</span><br><span> DLLC,</span><br><span> DSNDCP,</span><br><span> DSLHC,</span><br><span>diff --git a/src/gbproxy/gb_proxy_main.c b/src/gbproxy/gb_proxy_main.c</span><br><span>index c7ff78c..a9c132e 100644</span><br><span>--- a/src/gbproxy/gb_proxy_main.c</span><br><span>+++ b/src/gbproxy/gb_proxy_main.c</span><br><span>@@ -209,11 +209,6 @@</span><br><span> .description = "GPRS Network Service (NS)",</span><br><span> .enabled = 1, .loglevel = LOGL_INFO,</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- [DBSSGP] = {</span><br><span style="color: hsl(0, 100%, 40%);">- .name = "DBSSGP",</span><br><span style="color: hsl(0, 100%, 40%);">- .description = "GPRS BSS Gateway Protocol (BSSGP)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span> };</span><br><span> </span><br><span> static const struct log_info gprs_log_info = {</span><br><span>@@ -288,7 +283,7 @@</span><br><span> }</span><br><span> </span><br><span> gprs_ns2_vty_init(gbcfg->nsi, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">- bssgp_set_log_ss(DBSSGP);</span><br><span style="color: hsl(120, 100%, 40%);">+ logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "bssgp");</span><br><span> gprs_ns2_dynamic_create_nse(gbcfg->nsi, true);</span><br><span> </span><br><span> bssgp_set_bssgp_callback(gbprox_bssgp_send_cb, gbcfg);</span><br><span>diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c</span><br><span>index e51336b..0277f6f 100644</span><br><span>--- a/src/sgsn/sgsn_main.c</span><br><span>+++ b/src/sgsn/sgsn_main.c</span><br><span>@@ -312,11 +312,6 @@</span><br><span> .description = "GPRS Network Service (NS)",</span><br><span> .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- [DBSSGP] = {</span><br><span style="color: hsl(0, 100%, 40%);">- .name = "DBSSGP",</span><br><span style="color: hsl(0, 100%, 40%);">- .description = "GPRS BSS Gateway Protocol (BSSGP)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span> [DLLC] = {</span><br><span> .name = "DLLC",</span><br><span> .description = "GPRS Logical Link Control Protocol (LLC)",</span><br><span>@@ -424,7 +419,7 @@</span><br><span> rate_ctr_init(tall_sgsn_ctx);</span><br><span> </span><br><span> gprs_ns_set_log_ss(DNS);</span><br><span style="color: hsl(0, 100%, 40%);">- bssgp_set_log_ss(DBSSGP);</span><br><span style="color: hsl(120, 100%, 40%);">+ logging_vty_add_deprecated_subsys(tall_sgsn_ctx, "bssgp");</span><br><span> </span><br><span> sgsn_nsi = gprs_ns_instantiate(&sgsn_ns_cb, tall_sgsn_ctx);</span><br><span> if (!sgsn_nsi) {</span><br><span>diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c</span><br><span>index 7399573..0574620 100644</span><br><span>--- a/tests/sgsn/sgsn_test.c</span><br><span>+++ b/tests/sgsn/sgsn_test.c</span><br><span>@@ -1625,11 +1625,6 @@</span><br><span> .description = "GPRS Network Service (NS)",</span><br><span> .enabled = 1, .loglevel = LOGL_INFO,</span><br><span> },</span><br><span style="color: hsl(0, 100%, 40%);">- [DBSSGP] = {</span><br><span style="color: hsl(0, 100%, 40%);">- .name = "DBSSGP",</span><br><span style="color: hsl(0, 100%, 40%);">- .description = "GPRS BSS Gateway Protocol (BSSGP)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span> [DLLC] = {</span><br><span> .name = "DLLC",</span><br><span> .description = "GPRS Logical Link Control Protocol (LLC)",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21657">change 21657</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21657"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I69ee10b6fad1da2053cf6f3ae99d3ecf62a144ce </div>
<div style="display:none"> Gerrit-Change-Number: 21657 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>