Change in openbsc[master]: Add very clear obsolescence / unmaintained warnings

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/21646 )


Change subject: Add very clear obsolescence / unmaintained warnings
......................................................................

Add very clear obsolescence / unmaintained warnings

* add messages at start-up and to the VTY
* users must explicitly confirm they want to run osmo-nitb

Change-Id: I5d5c0ff386dbc2e7b7dd02d6c33d1f9fec70707b
---
M openbsc/src/libcommon/bsc_version.c
M openbsc/src/osmo-nitb/bsc_hack.c
2 files changed, 36 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/46/21646/1

diff --git a/openbsc/src/libcommon/bsc_version.c b/openbsc/src/libcommon/bsc_version.c
index f0369bf..9111a0e 100644
--- a/openbsc/src/libcommon/bsc_version.c
+++ b/openbsc/src/libcommon/bsc_version.c
@@ -19,12 +19,19 @@
 
 #include "../../bscconfig.h"
 
+#define DIVIDER  "======================================================================\r\n"
 const char *openbsc_copyright =
 	"Copyright (C) 2008-2016 Harald Welte, Holger Freyther\r\n"
 	"Contributions by Daniel Willmann, Jan Lübbe, Stefan Schmidt\r\n"
 	"Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n\r\n"
 	"License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n"
 	"This is free software: you are free to change and redistribute it.\r\n"
-	"There is NO WARRANTY, to the extent permitted by law.\r\n";
+	"There is NO WARRANTY, to the extent permitted by law.\r\n" DIVIDER
+	"WARNING: You should not run osmo-nitb except for archaeological purpose.\r\n"
+	"It is ancient, unmaintained and obsolete for several years.  But you seem\r\n"
+	"to insist on using obsolete and known-broken software that ignores years \r\n"
+	"of hard development work. That's your choice, but you have been warned.\r\n"
+	"DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\r\n"
+	"See https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\r\n" DIVIDER;
 
 
diff --git a/openbsc/src/osmo-nitb/bsc_hack.c b/openbsc/src/osmo-nitb/bsc_hack.c
index 4950f4c..9ce5e12 100644
--- a/openbsc/src/osmo-nitb/bsc_hack.c
+++ b/openbsc/src/osmo-nitb/bsc_hack.c
@@ -65,6 +65,7 @@
 static int daemonize = 0;
 static const char *mncc_sock_path = NULL;
 static int use_db_counter = 1;
+static bool yes_i_really_want = false;
 
 /* timer to store statistics */
 #define DB_SYNC_INTERVAL	60, 0
@@ -115,6 +116,7 @@
 	while (1) {
 		int option_index = 0, c;
 		static struct option long_options[] = {
+			{"yes-i-really-want-to-run-prehistoric-software", 0, 0, 0},
 			{"help", 0, 0, 'h'},
 			{"debug", 1, 0, 'd'},
 			{"daemonize", 0, 0, 'D'},
@@ -139,6 +141,10 @@
 			break;
 
 		switch (c) {
+		case 0:
+			if (option_index == 0)
+				yes_i_really_want = true;
+			break;
 		case 'h':
 			print_usage();
 			print_help();
@@ -282,6 +288,28 @@
 	/* Parse options */
 	handle_options(argc, argv);
 
+#define DIVIDER	"======================================================================\n"
+	if (!yes_i_really_want) {
+		fprintf(stderr, DIVIDER
+			"ERROR: You should not run osmo-nitb. It is ancient, unmaintained and\n"
+			"obsolete for several years.  If you really want to ignore years of hard work on\n"
+			"the new post-NITB stack (osmo-bsc, osmo-mgw, osmo-msc, osmo-hlr, osmo-stp),\n"
+			"you may ues the '--yes-i-really-want-to-run-prehistoric-software' command line\n"
+			"argument.  DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\n"
+			"Use https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\n"
+			DIVIDER);
+		exit(2);
+	} else {
+		fprintf(stderr, DIVIDER
+			"WARNING: You should not run osmo-nitb except for archaeological purpose.\n"
+			"It is ancient, unmaintained and obsolete for several years.  But you seem\n"
+			"to insist on using obsolete and known-broken software that ignores years \n"
+			"of hard development work. That's your choice, but you have been warned.\n"
+			"DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\n"
+			"Use https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\n"
+			DIVIDER);
+	}
+
 	/* Allocate global gsm_network struct; choose socket/internal MNCC */
 	rc = bsc_network_alloc(mncc_sock_path?
 			       mncc_sock_from_cc : int_mncc_recv);

-- 
To view, visit https://gerrit.osmocom.org/c/openbsc/+/21646
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: I5d5c0ff386dbc2e7b7dd02d6c33d1f9fec70707b
Gerrit-Change-Number: 21646
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201210/95737004/attachment.htm>