<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/openbsc/+/21646">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add very clear obsolescence / unmaintained warnings<br><br>* add messages at start-up and to the VTY<br>* users must explicitly confirm they want to run osmo-nitb<br><br>Change-Id: I5d5c0ff386dbc2e7b7dd02d6c33d1f9fec70707b<br>---<br>M openbsc/src/libcommon/bsc_version.c<br>M openbsc/src/osmo-nitb/bsc_hack.c<br>2 files changed, 36 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/46/21646/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/libcommon/bsc_version.c b/openbsc/src/libcommon/bsc_version.c</span><br><span>index f0369bf..9111a0e 100644</span><br><span>--- a/openbsc/src/libcommon/bsc_version.c</span><br><span>+++ b/openbsc/src/libcommon/bsc_version.c</span><br><span>@@ -19,12 +19,19 @@</span><br><span> </span><br><span> #include "../../bscconfig.h"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define DIVIDER "======================================================================\r\n"</span><br><span> const char *openbsc_copyright =</span><br><span> "Copyright (C) 2008-2016 Harald Welte, Holger Freyther\r\n"</span><br><span> "Contributions by Daniel Willmann, Jan Lübbe, Stefan Schmidt\r\n"</span><br><span> "Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n\r\n"</span><br><span> "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n"</span><br><span> "This is free software: you are free to change and redistribute it.\r\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "There is NO WARRANTY, to the extent permitted by law.\r\n";</span><br><span style="color: hsl(120, 100%, 40%);">+ "There is NO WARRANTY, to the extent permitted by law.\r\n" DIVIDER</span><br><span style="color: hsl(120, 100%, 40%);">+ "WARNING: You should not run osmo-nitb except for archaeological purpose.\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "It is ancient, unmaintained and obsolete for several years. But you seem\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "to insist on using obsolete and known-broken software that ignores years \r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "of hard development work. That's your choice, but you have been warned.\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\r\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "See https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\r\n" DIVIDER;</span><br><span> </span><br><span> </span><br><span>diff --git a/openbsc/src/osmo-nitb/bsc_hack.c b/openbsc/src/osmo-nitb/bsc_hack.c</span><br><span>index 4950f4c..9ce5e12 100644</span><br><span>--- a/openbsc/src/osmo-nitb/bsc_hack.c</span><br><span>+++ b/openbsc/src/osmo-nitb/bsc_hack.c</span><br><span>@@ -65,6 +65,7 @@</span><br><span> static int daemonize = 0;</span><br><span> static const char *mncc_sock_path = NULL;</span><br><span> static int use_db_counter = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+static bool yes_i_really_want = false;</span><br><span> </span><br><span> /* timer to store statistics */</span><br><span> #define DB_SYNC_INTERVAL 60, 0</span><br><span>@@ -115,6 +116,7 @@</span><br><span> while (1) {</span><br><span> int option_index = 0, c;</span><br><span> static struct option long_options[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ {"yes-i-really-want-to-run-prehistoric-software", 0, 0, 0},</span><br><span> {"help", 0, 0, 'h'},</span><br><span> {"debug", 1, 0, 'd'},</span><br><span> {"daemonize", 0, 0, 'D'},</span><br><span>@@ -139,6 +141,10 @@</span><br><span> break;</span><br><span> </span><br><span> switch (c) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (option_index == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ yes_i_really_want = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> case 'h':</span><br><span> print_usage();</span><br><span> print_help();</span><br><span>@@ -282,6 +288,28 @@</span><br><span> /* Parse options */</span><br><span> handle_options(argc, argv);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define DIVIDER "======================================================================\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!yes_i_really_want) {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, DIVIDER</span><br><span style="color: hsl(120, 100%, 40%);">+ "ERROR: You should not run osmo-nitb. It is ancient, unmaintained and\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "obsolete for several years. If you really want to ignore years of hard work on\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "the new post-NITB stack (osmo-bsc, osmo-mgw, osmo-msc, osmo-hlr, osmo-stp),\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "you may ues the '--yes-i-really-want-to-run-prehistoric-software' command line\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "argument. DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Use https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ DIVIDER);</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, DIVIDER</span><br><span style="color: hsl(120, 100%, 40%);">+ "WARNING: You should not run osmo-nitb except for archaeological purpose.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "It is ancient, unmaintained and obsolete for several years. But you seem\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "to insist on using obsolete and known-broken software that ignores years \n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "of hard development work. That's your choice, but you have been warned.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "DON'T EVER BOTHER THE DEVELOPERS IF YOU ENCOUNTER PROBLEMS WITH IT!!!\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Use https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Network_In_The_Box\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ DIVIDER);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Allocate global gsm_network struct; choose socket/internal MNCC */</span><br><span> rc = bsc_network_alloc(mncc_sock_path?</span><br><span> mncc_sock_from_cc : int_mncc_recv);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/openbsc/+/21646">change 21646</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/openbsc/+/21646"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5d5c0ff386dbc2e7b7dd02d6c33d1f9fec70707b </div>
<div style="display:none"> Gerrit-Change-Number: 21646 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>