Change in osmo-ttcn3-hacks[master]: NS_Emulation: Tolerate late NS-BLOCK-ACK / NS-UNBLOCK-ACK

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21586 )


Change subject: NS_Emulation: Tolerate late NS-BLOCK-ACK / NS-UNBLOCK-ACK
......................................................................

NS_Emulation: Tolerate late NS-BLOCK-ACK / NS-UNBLOCK-ACK

Particularly in case both sides initiate a BLOCK or UNBLOCK procedure
at almost the same time, it can happen thet we're already in BLOCKED
state and receive a late BLOCK-ACK or in UNBLOCKED state and receive a
late UNBLOCK-ACK.

Let's just silently discard them instaed of generating NS-STATUS which
may confuse the peer.

Change-Id: I2e5b934e1cf6c6cf982d5ab1dbb32e8920b91071
---
M library/NS_Emulation.ttcnpp
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/21586/1

diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp
index ab1c136..2ccd399 100644
--- a/library/NS_Emulation.ttcnpp
+++ b/library/NS_Emulation.ttcnpp
@@ -561,6 +561,9 @@
 			Tns_block.stop;
 			f_change_state(NSVC_S_ALIVE_UNBLOCKED);
 		}
+		/* tolerate a late NS-BLOCK-ACK from peer */
+		[] NSCP.receive(tr_NS_BLOCK_ACK(g_nsvc_config.nsvci)) -> value rf {
+		}
 		[] Tns_block.timeout {
 			/* repeat unblock transmission */
 			f_sendUnblock();
@@ -583,6 +586,9 @@
 		[] NSCP.receive(tr_NS_BLOCK_ACK(g_nsvc_config.nsvci)) -> value rf {
 			Tns_block.stop;
 		}
+		/* tolerate a late NS-UNBLOCK-ACK from peer */
+		[] NSCP.receive(t_NS_UNBLOCK_ACK) -> value rf {
+		}
 		/* NS-UNITDATA PDU from network to NS-UNITDATA.ind to user */
 		[] NSCP.receive(tr_NS_UNITDATA(?, ?, ?)) -> value rf {
 			NS_SP.send(ts_NsUdInd(g_config.nsei, g_nsvc_config.nsvci,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21586
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2e5b934e1cf6c6cf982d5ab1dbb32e8920b91071
Gerrit-Change-Number: 21586
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201207/13f4097b/attachment.htm>