<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21586">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NS_Emulation: Tolerate late NS-BLOCK-ACK / NS-UNBLOCK-ACK<br><br>Particularly in case both sides initiate a BLOCK or UNBLOCK procedure<br>at almost the same time, it can happen thet we're already in BLOCKED<br>state and receive a late BLOCK-ACK or in UNBLOCKED state and receive a<br>late UNBLOCK-ACK.<br><br>Let's just silently discard them instaed of generating NS-STATUS which<br>may confuse the peer.<br><br>Change-Id: I2e5b934e1cf6c6cf982d5ab1dbb32e8920b91071<br>---<br>M library/NS_Emulation.ttcnpp<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/21586/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp</span><br><span>index ab1c136..2ccd399 100644</span><br><span>--- a/library/NS_Emulation.ttcnpp</span><br><span>+++ b/library/NS_Emulation.ttcnpp</span><br><span>@@ -561,6 +561,9 @@</span><br><span>                  Tns_block.stop;</span><br><span>                      f_change_state(NSVC_S_ALIVE_UNBLOCKED);</span><br><span>              }</span><br><span style="color: hsl(120, 100%, 40%);">+             /* tolerate a late NS-BLOCK-ACK from peer */</span><br><span style="color: hsl(120, 100%, 40%);">+          [] NSCP.receive(tr_NS_BLOCK_ACK(g_nsvc_config.nsvci)) -> value rf {</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>            [] Tns_block.timeout {</span><br><span>                       /* repeat unblock transmission */</span><br><span>                    f_sendUnblock();</span><br><span>@@ -583,6 +586,9 @@</span><br><span>               [] NSCP.receive(tr_NS_BLOCK_ACK(g_nsvc_config.nsvci)) -> value rf {</span><br><span>                       Tns_block.stop;</span><br><span>              }</span><br><span style="color: hsl(120, 100%, 40%);">+             /* tolerate a late NS-UNBLOCK-ACK from peer */</span><br><span style="color: hsl(120, 100%, 40%);">+                [] NSCP.receive(t_NS_UNBLOCK_ACK) -> value rf {</span><br><span style="color: hsl(120, 100%, 40%);">+            }</span><br><span>            /* NS-UNITDATA PDU from network to NS-UNITDATA.ind to user */</span><br><span>                [] NSCP.receive(tr_NS_UNITDATA(?, ?, ?)) -> value rf {</span><br><span>                    NS_SP.send(ts_NsUdInd(g_config.nsei, g_nsvc_config.nsvci,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21586">change 21586</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21586"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2e5b934e1cf6c6cf982d5ab1dbb32e8920b91071 </div>
<div style="display:none"> Gerrit-Change-Number: 21586 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>