Change in osmo-gsm-tester[master]: typo / newline in selftest log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Dec 4 17:43:42 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21542 )


Change subject: typo / newline in selftest log output
......................................................................

typo / newline in selftest log output

...because it otherwise causes confusing selftest log changes in
upcoming I0972c66b9165bd7f2b0b387e0335172849199193

Change-Id: I1eec31c5baba5ef33d0c8441b1e94a00d79af9bf
---
M selftest/suite_test/suite_test.ok
M selftest/suite_test/suitedirB/suiteC/test_template_overlay.py
M selftest/template_test/template_test.ok
M selftest/template_test/template_test.py
4 files changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/42/21542/1

diff --git a/selftest/suite_test/suite_test.ok b/selftest/suite_test/suite_test.ok
index 7bcddef..6ed7619 100644
--- a/selftest/suite_test/suite_test.ok
+++ b/selftest/suite_test/suite_test.ok
@@ -1242,8 +1242,7 @@
 ----------------------------------------------
 tst test_template_overlay.py:[LINENR]: - Testing: expect to fail on invalid templates overlay dir  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]
 tst test_template_overlay.py:[LINENR] DBG: template dir overlay set: [PATH]/selftest/suite_test/suitedirB/suiteC/nonexistent-templatedir  [suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]  [testenv.py:[LINENR]]
-tst test_template_overlay.py:[LINENR]: sucess: setting non-existing templates dir raised RuntimeError  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]
-tst test_template_overlay.py:[LINENR]:   [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]
+tst test_template_overlay.py:[LINENR]: success: setting non-existing templates dir raised RuntimeError  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]
 tst test_template_overlay.py:[LINENR] DBG: template dir overlay set: [PATH]/selftest/suite_test/suitedirB/suiteC/mytemplatedir  [suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]  [testenv.py:[LINENR]]
 --- ReservedResources: DBG: requesting use of ip_address {specifics={}}  [resource.py:[LINENR]]
 tst suiteC: Using 1 x ip_address (candidates: 1)  [resource.py:[LINENR]]
diff --git a/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py b/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py
index 2dd9378..7d35138 100644
--- a/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py
+++ b/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py
@@ -11,7 +11,7 @@
     sys.stderr.write('Error: setting non-existing templates dir should raise RuntimeError\n')
     assert(False)
 except RuntimeError:
-    print('sucess: setting non-existing templates dir raised RuntimeError\n')
+    print('success: setting non-existing templates dir raised RuntimeError')
     pass
 
 mytemplatedir = os.path.join(os.path.dirname(__file__), 'mytemplatedir')
diff --git a/selftest/template_test/template_test.ok b/selftest/template_test/template_test.ok
index 718ef6e..39b0cd3 100644
--- a/selftest/template_test/template_test.ok
+++ b/selftest/template_test/template_test.ok
@@ -189,8 +189,7 @@
  bind val_ip_address
 
 - Testing: expect to fail on invalid templates dir
-sucess: setting non-existing templates dir raised RuntimeError
-
+success: setting non-existing templates dir raised RuntimeError
 - Testing: template directory overlay (still can find default one?)
 cnf Templates: DBG: rendering osmo-nitb.cfg.tmpl
 ! Configuration rendered by osmo-gsm-tester
diff --git a/selftest/template_test/template_test.py b/selftest/template_test/template_test.py
index 52976e5..9dc967f 100755
--- a/selftest/template_test/template_test.py
+++ b/selftest/template_test/template_test.py
@@ -89,7 +89,7 @@
     assert(False)
 except RuntimeError:
     # not logging exception to omit non-constant path name from expected output
-    print('sucess: setting non-existing templates dir raised RuntimeError\n')
+    print('success: setting non-existing templates dir raised RuntimeError')
     pass
 
 mytemplatedir = os.path.join(os.path.dirname(__file__), 'mytemplatedir')

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21542
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I1eec31c5baba5ef33d0c8441b1e94a00d79af9bf
Gerrit-Change-Number: 21542
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201204/370a2a0c/attachment.htm>


More information about the gerrit-log mailing list