<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21542">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">typo / newline in selftest log output<br><br>...because it otherwise causes confusing selftest log changes in<br>upcoming I0972c66b9165bd7f2b0b387e0335172849199193<br><br>Change-Id: I1eec31c5baba5ef33d0c8441b1e94a00d79af9bf<br>---<br>M selftest/suite_test/suite_test.ok<br>M selftest/suite_test/suitedirB/suiteC/test_template_overlay.py<br>M selftest/template_test/template_test.ok<br>M selftest/template_test/template_test.py<br>4 files changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/42/21542/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/selftest/suite_test/suite_test.ok b/selftest/suite_test/suite_test.ok</span><br><span>index 7bcddef..6ed7619 100644</span><br><span>--- a/selftest/suite_test/suite_test.ok</span><br><span>+++ b/selftest/suite_test/suite_test.ok</span><br><span>@@ -1242,8 +1242,7 @@</span><br><span> ----------------------------------------------</span><br><span> tst test_template_overlay.py:[LINENR]: - Testing: expect to fail on invalid templates overlay dir  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]</span><br><span> tst test_template_overlay.py:[LINENR] DBG: template dir overlay set: [PATH]/selftest/suite_test/suitedirB/suiteC/nonexistent-templatedir  [suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]  [testenv.py:[LINENR]]</span><br><span style="color: hsl(0, 100%, 40%);">-tst test_template_overlay.py:[LINENR]: sucess: setting non-existing templates dir raised RuntimeError  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]</span><br><span style="color: hsl(0, 100%, 40%);">-tst test_template_overlay.py:[LINENR]:   [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]</span><br><span style="color: hsl(120, 100%, 40%);">+tst test_template_overlay.py:[LINENR]: success: setting non-existing templates dir raised RuntimeError  [suiteC↪test_template_overlay.py:[LINENR]]  [test_template_overlay.py:[LINENR]]</span><br><span> tst test_template_overlay.py:[LINENR] DBG: template dir overlay set: [PATH]/selftest/suite_test/suitedirB/suiteC/mytemplatedir  [suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]  [testenv.py:[LINENR]]</span><br><span> --- ReservedResources: DBG: requesting use of ip_address {specifics={}}  [resource.py:[LINENR]]</span><br><span> tst suiteC: Using 1 x ip_address (candidates: 1)  [resource.py:[LINENR]]</span><br><span>diff --git a/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py b/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py</span><br><span>index 2dd9378..7d35138 100644</span><br><span>--- a/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py</span><br><span>+++ b/selftest/suite_test/suitedirB/suiteC/test_template_overlay.py</span><br><span>@@ -11,7 +11,7 @@</span><br><span>     sys.stderr.write('Error: setting non-existing templates dir should raise RuntimeError\n')</span><br><span>     assert(False)</span><br><span> except RuntimeError:</span><br><span style="color: hsl(0, 100%, 40%);">-    print('sucess: setting non-existing templates dir raised RuntimeError\n')</span><br><span style="color: hsl(120, 100%, 40%);">+    print('success: setting non-existing templates dir raised RuntimeError')</span><br><span>     pass</span><br><span> </span><br><span> mytemplatedir = os.path.join(os.path.dirname(__file__), 'mytemplatedir')</span><br><span>diff --git a/selftest/template_test/template_test.ok b/selftest/template_test/template_test.ok</span><br><span>index 718ef6e..39b0cd3 100644</span><br><span>--- a/selftest/template_test/template_test.ok</span><br><span>+++ b/selftest/template_test/template_test.ok</span><br><span>@@ -189,8 +189,7 @@</span><br><span>  bind val_ip_address</span><br><span> </span><br><span> - Testing: expect to fail on invalid templates dir</span><br><span style="color: hsl(0, 100%, 40%);">-sucess: setting non-existing templates dir raised RuntimeError</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+success: setting non-existing templates dir raised RuntimeError</span><br><span> - Testing: template directory overlay (still can find default one?)</span><br><span> cnf Templates: DBG: rendering osmo-nitb.cfg.tmpl</span><br><span> ! Configuration rendered by osmo-gsm-tester</span><br><span>diff --git a/selftest/template_test/template_test.py b/selftest/template_test/template_test.py</span><br><span>index 52976e5..9dc967f 100755</span><br><span>--- a/selftest/template_test/template_test.py</span><br><span>+++ b/selftest/template_test/template_test.py</span><br><span>@@ -89,7 +89,7 @@</span><br><span>     assert(False)</span><br><span> except RuntimeError:</span><br><span>     # not logging exception to omit non-constant path name from expected output</span><br><span style="color: hsl(0, 100%, 40%);">-    print('sucess: setting non-existing templates dir raised RuntimeError\n')</span><br><span style="color: hsl(120, 100%, 40%);">+    print('success: setting non-existing templates dir raised RuntimeError')</span><br><span>     pass</span><br><span> </span><br><span> mytemplatedir = os.path.join(os.path.dirname(__file__), 'mytemplatedir')</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21542">change 21542</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21542"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1eec31c5baba5ef33d0c8441b1e94a00d79af9bf </div>
<div style="display:none"> Gerrit-Change-Number: 21542 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>