Change in osmo-bts[master]: l1sap: make sure that UL SACCH is always 23 octets long

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Dec 1 17:41:33 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21439 )


Change subject: l1sap: make sure that UL SACCH is always 23 octets long
......................................................................

l1sap: make sure that UL SACCH is always 23 octets long

Change-Id: I1c8a43337fbc1acfab3c0f0713c75ded95d69512
Related: SYS#4918
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/21439/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 1785e66..2038fba 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1531,8 +1531,8 @@
 		radio_link_timeout(lchan, false);
 		le = &lchan->lapdm_ch.lapdm_acch;
 		/* save the SACCH L1 header in the lchan struct for RSL MEAS RES */
-		if (len < 2) {
-			LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with size %u<2 !?!\n", len);
+		if (len != GSM_MACBLOCK_LEN) {
+			LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with odd len=%u!?!\n", len);
 			return -EINVAL;
 		}
 		/* Some brilliant engineer decided that the ordering of

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21439
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1c8a43337fbc1acfab3c0f0713c75ded95d69512
Gerrit-Change-Number: 21439
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/9e159ce1/attachment.htm>


More information about the gerrit-log mailing list