<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21439">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: make sure that UL SACCH is always 23 octets long<br><br>Change-Id: I1c8a43337fbc1acfab3c0f0713c75ded95d69512<br>Related: SYS#4918<br>---<br>M src/common/l1sap.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/21439/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 1785e66..2038fba 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1531,8 +1531,8 @@</span><br><span>               radio_link_timeout(lchan, false);</span><br><span>            le = &lchan->lapdm_ch.lapdm_acch;</span><br><span>             /* save the SACCH L1 header in the lchan struct for RSL MEAS RES */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (len < 2) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with size %u<2 !?!\n", len);</span><br><span style="color: hsl(120, 100%, 40%);">+               if (len != GSM_MACBLOCK_LEN) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with odd len=%u!?!\n", len);</span><br><span>                         return -EINVAL;</span><br><span>              }</span><br><span>            /* Some brilliant engineer decided that the ordering of</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21439">change 21439</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21439"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1c8a43337fbc1acfab3c0f0713c75ded95d69512 </div>
<div style="display:none"> Gerrit-Change-Number: 21439 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>