Change in osmo-pcu[master]: tbf: cosmetic: use GSM_MACBLOCK_LEN where possible

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Aug 21 16:24:39 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19776 )


Change subject: tbf: cosmetic: use GSM_MACBLOCK_LEN where possible
......................................................................

tbf: cosmetic: use GSM_MACBLOCK_LEN where possible

Change-Id: Ib42770cb009e8d559f733ebedd058e2f0a18820a
---
M src/tbf.cpp
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/19776/1

diff --git a/src/tbf.cpp b/src/tbf.cpp
index 2d78ef8..644b947 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1252,7 +1252,7 @@
 	}
 
 	new_dl_tbf->was_releasing = was_releasing;
-	msg = msgb_alloc(23, "rlcmac_dl_ass");
+	msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_dl_ass");
 	if (!msg)
 		return NULL;
 	struct bitvec bv = {
@@ -1300,9 +1300,9 @@
 {
 	struct msgb *msg;
 
-	msg = msgb_alloc(23, "rlcmac_ul_ass_rej");
+	msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass_rej");
 
-	bitvec *packet_access_rej = bitvec_alloc(23, tall_pcu_ctx);
+	bitvec *packet_access_rej = bitvec_alloc(GSM_MACBLOCK_LEN, tall_pcu_ctx);
 
 	bitvec_unhex(packet_access_rej, DUMMY_VEC);
 
@@ -1311,7 +1311,7 @@
 
 	bts->do_rate_ctr_inc(CTR_PKT_ACCESS_REJ);
 
-	bitvec_pack(packet_access_rej, msgb_put(msg, 23));
+	bitvec_pack(packet_access_rej, msgb_put(msg, GSM_MACBLOCK_LEN));
 
 	bitvec_free(packet_access_rej);
 	ul_ass_state = GPRS_RLCMAC_UL_ASS_NONE;
@@ -1353,7 +1353,7 @@
 		return NULL;
 	}
 
-	msg = msgb_alloc(23, "rlcmac_ul_ass");
+	msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass");
 	if (!msg)
 		return NULL;
 	struct bitvec bv = {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19776
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib42770cb009e8d559f733ebedd058e2f0a18820a
Gerrit-Change-Number: 19776
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200821/33e02441/attachment.htm>


More information about the gerrit-log mailing list