<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19776">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf: cosmetic: use GSM_MACBLOCK_LEN where possible<br><br>Change-Id: Ib42770cb009e8d559f733ebedd058e2f0a18820a<br>---<br>M src/tbf.cpp<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/19776/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 2d78ef8..644b947 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -1252,7 +1252,7 @@</span><br><span>  }</span><br><span> </span><br><span>        new_dl_tbf->was_releasing = was_releasing;</span><br><span style="color: hsl(0, 100%, 40%);">-   msg = msgb_alloc(23, "rlcmac_dl_ass");</span><br><span style="color: hsl(120, 100%, 40%);">+      msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_dl_ass");</span><br><span>       if (!msg)</span><br><span>            return NULL;</span><br><span>         struct bitvec bv = {</span><br><span>@@ -1300,9 +1300,9 @@</span><br><span> {</span><br><span>    struct msgb *msg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   msg = msgb_alloc(23, "rlcmac_ul_ass_rej");</span><br><span style="color: hsl(120, 100%, 40%);">+  msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass_rej");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  bitvec *packet_access_rej = bitvec_alloc(23, tall_pcu_ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+   bitvec *packet_access_rej = bitvec_alloc(GSM_MACBLOCK_LEN, tall_pcu_ctx);</span><br><span> </span><br><span>        bitvec_unhex(packet_access_rej, DUMMY_VEC);</span><br><span> </span><br><span>@@ -1311,7 +1311,7 @@</span><br><span> </span><br><span>  bts->do_rate_ctr_inc(CTR_PKT_ACCESS_REJ);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        bitvec_pack(packet_access_rej, msgb_put(msg, 23));</span><br><span style="color: hsl(120, 100%, 40%);">+    bitvec_pack(packet_access_rej, msgb_put(msg, GSM_MACBLOCK_LEN));</span><br><span> </span><br><span>         bitvec_free(packet_access_rej);</span><br><span>      ul_ass_state = GPRS_RLCMAC_UL_ASS_NONE;</span><br><span>@@ -1353,7 +1353,7 @@</span><br><span>              return NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   msg = msgb_alloc(23, "rlcmac_ul_ass");</span><br><span style="color: hsl(120, 100%, 40%);">+      msg = msgb_alloc(GSM_MACBLOCK_LEN, "rlcmac_ul_ass");</span><br><span>       if (!msg)</span><br><span>            return NULL;</span><br><span>         struct bitvec bv = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19776">change 19776</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/19776"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib42770cb009e8d559f733ebedd058e2f0a18820a </div>
<div style="display:none"> Gerrit-Change-Number: 19776 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>