Change in osmo-ttcn3-hacks[master]: CBSP_Templates: Fix tons of compiler warnings

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19750 )

Change subject: CBSP_Templates: Fix tons of compiler warnings
......................................................................

CBSP_Templates: Fix tons of compiler warnings

 CBSP_Templates.ttcn:385.1-401.1: In function definition `ts_CBSP_REPLACE_CBS_COMPL':
  CBSP_Templates.ttcn:396.2-398.2: In if statement:
   CBSP_Templates.ttcn:397.3-50: In variable assignment:
    CBSP_Templates.ttcn:397.40-50: In actual parameter list of template `@CBSP_Templates.ts_CbspCellList':
     CBSP_Templates.ttcn:397.41-49: In parameter #1 for `list':
      CBSP_Templates.ttcn:397.41-49: warning: Inadequate restriction on the referenced template parameter `cell_list', this may cause a dynamic test case error at runtime
      CBSP_Templates.ttcn:387.8-68: note: Referenced template parameter is here

Change-Id: I54c21d17ab3235ec37d5f07867d8c6c83d699088
---
M library/CBSP_Templates.ttcn
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/CBSP_Templates.ttcn b/library/CBSP_Templates.ttcn
index 8d62742..5ee1f33 100644
--- a/library/CBSP_Templates.ttcn
+++ b/library/CBSP_Templates.ttcn
@@ -354,7 +354,7 @@
 		ts_NewSerNo(new_ser_nr)
 	};
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);
 	return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_COMPL, ies);
@@ -394,7 +394,7 @@
 		ts_CbspNumComplList(compl_list)
 	};
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);
 	return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_COMPL, ies);
@@ -439,10 +439,10 @@
 		ts_CbspFailList(fail_list)
 	};
 	if (not istemplatekind(compl_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);
+		ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));
 	}
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);
 	return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_FAIL, ies);
@@ -493,10 +493,10 @@
 		ts_CbspFailList(fail_list)
 	};
 	if (not istemplatekind(compl_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);
+		ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));
 	}
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);
 	return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_FAIL, ies);
@@ -562,10 +562,10 @@
 		ts_OldSerNo(old_ser_nr)
 	};
 	if (not istemplatekind(compl_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);
+		ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));
 	}
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	if (not istemplatekind(channel_ind, "omit")) {
 		ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);
@@ -621,10 +621,10 @@
 		ts_CbspFailList(fail_list)
 	};
 	if (not istemplatekind(compl_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);
+		ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));
 	}
 	if (not istemplatekind(cell_list, "omit")) {
-		ies[lengthof(ies)] := ts_CbspCellList(cell_list);
+		ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));
 	}
 	if (not istemplatekind(channel_ind, "omit")) {
 		ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I54c21d17ab3235ec37d5f07867d8c6c83d699088
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200821/f58690ad/attachment.htm>