<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19750">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CBSP_Templates: Fix tons of compiler warnings<br><br> CBSP_Templates.ttcn:385.1-401.1: In function definition `ts_CBSP_REPLACE_CBS_COMPL':<br> CBSP_Templates.ttcn:396.2-398.2: In if statement:<br> CBSP_Templates.ttcn:397.3-50: In variable assignment:<br> CBSP_Templates.ttcn:397.40-50: In actual parameter list of template `@CBSP_Templates.ts_CbspCellList':<br> CBSP_Templates.ttcn:397.41-49: In parameter #1 for `list':<br> CBSP_Templates.ttcn:397.41-49: warning: Inadequate restriction on the referenced template parameter `cell_list', this may cause a dynamic test case error at runtime<br> CBSP_Templates.ttcn:387.8-68: note: Referenced template parameter is here<br><br>Change-Id: I54c21d17ab3235ec37d5f07867d8c6c83d699088<br>---<br>M library/CBSP_Templates.ttcn<br>1 file changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/CBSP_Templates.ttcn b/library/CBSP_Templates.ttcn</span><br><span>index 8d62742..5ee1f33 100644</span><br><span>--- a/library/CBSP_Templates.ttcn</span><br><span>+++ b/library/CBSP_Templates.ttcn</span><br><span>@@ -354,7 +354,7 @@</span><br><span> ts_NewSerNo(new_ser_nr)</span><br><span> };</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span> return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_COMPL, ies);</span><br><span>@@ -394,7 +394,7 @@</span><br><span> ts_CbspNumComplList(compl_list)</span><br><span> };</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span> return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_COMPL, ies);</span><br><span>@@ -439,10 +439,10 @@</span><br><span> ts_CbspFailList(fail_list)</span><br><span> };</span><br><span> if (not istemplatekind(compl_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));</span><br><span> }</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span> return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_FAIL, ies);</span><br><span>@@ -493,10 +493,10 @@</span><br><span> ts_CbspFailList(fail_list)</span><br><span> };</span><br><span> if (not istemplatekind(compl_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));</span><br><span> }</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span> return ts_CBSP(CBSP_MSGT_WRITE_REPLACE_FAIL, ies);</span><br><span>@@ -562,10 +562,10 @@</span><br><span> ts_OldSerNo(old_ser_nr)</span><br><span> };</span><br><span> if (not istemplatekind(compl_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));</span><br><span> }</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> if (not istemplatekind(channel_ind, "omit")) {</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span>@@ -621,10 +621,10 @@</span><br><span> ts_CbspFailList(fail_list)</span><br><span> };</span><br><span> if (not istemplatekind(compl_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspNumComplList(compl_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspNumComplList(valueof(compl_list));</span><br><span> }</span><br><span> if (not istemplatekind(cell_list, "omit")) {</span><br><span style="color: hsl(0, 100%, 40%);">- ies[lengthof(ies)] := ts_CbspCellList(cell_list);</span><br><span style="color: hsl(120, 100%, 40%);">+ ies[lengthof(ies)] := ts_CbspCellList(valueof(cell_list));</span><br><span> }</span><br><span> if (not istemplatekind(channel_ind, "omit")) {</span><br><span> ies[lengthof(ies)] := ts_CbspChannelInd(channel_ind);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19750">change 19750</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19750"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I54c21d17ab3235ec37d5f07867d8c6c83d699088 </div>
<div style="display:none"> Gerrit-Change-Number: 19750 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>