Change in osmo-pcu[master]: pdch: Drop unneeded notice log message in rcv pkt meas report

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 18 18:31:18 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19705 )


Change subject: pdch: Drop unneeded notice log message in rcv pkt meas report
......................................................................

pdch: Drop unneeded notice log message in rcv pkt meas report

It's totally fine to receive Packet Measurement Report messages with no
SBA present, since the MS also sends measurements on PACCH while
transmitting data.

Related: OS#4719
Change-Id: I8f642d9cdeb342df7d5f2fa30516ea69554a6270
---
M src/pdch.cpp
1 file changed, 2 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/19705/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index 856da75..b34f532 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -652,15 +652,8 @@
 
 void gprs_rlcmac_pdch::rcv_measurement_report(Packet_Measurement_Report_t *report, uint32_t fn)
 {
-	struct gprs_rlcmac_sba *sba;
-
-	sba = bts()->sba()->find(this, fn);
-	if (!sba) {
-		LOGP(DRLCMAC, LOGL_NOTICE, "MS send measurement "
-			"in packet resource request of single "
-			"block, but there is no resource request "
-			"scheduled! TLLI=0x%08x\n", report->TLLI);
-	} else {
+	struct gprs_rlcmac_sba *sba = bts()->sba()->find(this, fn);
+	if (sba) {
 		GprsMs *ms = bts()->ms_store().get_ms(report->TLLI);
 		if (!ms)
 			LOGP(DRLCMAC, LOGL_NOTICE, "MS send measurement "

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19705
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8f642d9cdeb342df7d5f2fa30516ea69554a6270
Gerrit-Change-Number: 19705
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200818/711b5806/attachment.htm>


More information about the gerrit-log mailing list