<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19705">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Drop unneeded notice log message in rcv pkt meas report<br><br>It's totally fine to receive Packet Measurement Report messages with no<br>SBA present, since the MS also sends measurements on PACCH while<br>transmitting data.<br><br>Related: OS#4719<br>Change-Id: I8f642d9cdeb342df7d5f2fa30516ea69554a6270<br>---<br>M src/pdch.cpp<br>1 file changed, 2 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/19705/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index 856da75..b34f532 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -652,15 +652,8 @@</span><br><span> </span><br><span> void gprs_rlcmac_pdch::rcv_measurement_report(Packet_Measurement_Report_t *report, uint32_t fn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    struct gprs_rlcmac_sba *sba;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    sba = bts()->sba()->find(this, fn);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!sba) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DRLCMAC, LOGL_NOTICE, "MS send measurement "</span><br><span style="color: hsl(0, 100%, 40%);">-                     "in packet resource request of single "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "block, but there is no resource request "</span><br><span style="color: hsl(0, 100%, 40%);">-                    "scheduled! TLLI=0x%08x\n", report->TLLI);</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(120, 100%, 40%);">+      struct gprs_rlcmac_sba *sba = bts()->sba()->find(this, fn);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (sba) {</span><br><span>           GprsMs *ms = bts()->ms_store().get_ms(report->TLLI);</span><br><span>           if (!ms)</span><br><span>                     LOGP(DRLCMAC, LOGL_NOTICE, "MS send measurement "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19705">change 19705</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/19705"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8f642d9cdeb342df7d5f2fa30516ea69554a6270 </div>
<div style="display:none"> Gerrit-Change-Number: 19705 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>