This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19668 ) Change subject: vty: print program specific attributes in the XML reference ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@641 PS8, Line 641: if (~cmd->usrattr & (1 << i)) I find !(cmd->usrattr & (1 << i)) a lot easier to read/understand. https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@644 PS8, Line 644: char *xml_att_desc = xml_escape(host.app_info->usr_attr_desc[i]); Move var decl at the start of block, like done in loop below. https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@650 PS8, Line 650: print_func(data, " flag='%c'", 'a' + i); I'm not really liking this dynamic flag character generation, looks as if flag meaning could change over time. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1f35368ba9178e1454f2e3ddfcad9d96576143ef Gerrit-Change-Number: 19668 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 17 Aug 2020 14:36:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/52411b04/attachment.htm>