<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c">File src/vty/command.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@641">Patch Set #8, Line 641:</a> <code style="font-family:monospace,monospace">                       if (~cmd->usrattr & (1 << i))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I find  !(cmd->usrattr & (1 << i)) a lot easier to read/understand.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@644">Patch Set #8, Line 644:</a> <code style="font-family:monospace,monospace">                   char *xml_att_desc = xml_escape(host.app_info->usr_attr_desc[i]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Move var decl at the start of block, like done in loop below.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19668/8/src/vty/command.c@650">Patch Set #8, Line 650:</a> <code style="font-family:monospace,monospace">                            print_func(data, " flag='%c'", 'a' + i);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not really liking this dynamic flag character generation, looks as if flag meaning could change over time.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19668">change 19668</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19668"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f35368ba9178e1454f2e3ddfcad9d96576143ef </div>
<div style="display:none"> Gerrit-Change-Number: 19668 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Aug 2020 14:36:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>